Add DOMException #1040
Add DOMException #1040
Conversation
Implemented separately from the other errors because it is defined in terms of WebIDL, where members of an interface are getters on their prototype. See the difference between `JSON.stringify(Object.getOwnPropertyDescriptors(new TypeError()))` vs `JSON.stringify(Object.getOwnPropertyDescriptors(new DOMException()))`.
| @@ -285,10 +285,10 @@ function bjson_test_bytecode() | |||
| function bjson_test_fuzz() | |||
| { | |||
| var corpus = [ | |||
| "FBAAAAAABGA=", | |||
There was a problem hiding this comment.
Note: this was complaining because of the bytecode version, but I don't know how the corpus was generated so I just incremented it manually...
|
It's still missing a stack trace when created with the constructor... |
The standard doesn't specify where to put "stack". This follows node instead of browsers because it's more straightforward to implement it this way.
|
I was confused for a minute because browsers set |
|
Perhaps you could use Js_NewError and extract it? |
I think that should be fine. |
| name = JS_ToCString(ctx, s->name); | ||
| for (i = 0; i < countof(js_dom_exception_names_table); i++) { | ||
| if (js_dom_exception_names_table[i].name && | ||
| !strcmp(js_dom_exception_names_table[i].name, name)) { |
There was a problem hiding this comment.
Good catch, thank you. But I don't think strncmp helps here, that would do a prefix check but to catch NUL we need a length check.
Thanks to saghul for noticing.
Implemented separately from the other errors because it is defined in terms of WebIDL, where members of an interface are getters on their prototype.
See the difference between
JSON.stringify(Object.getOwnPropertyDescriptors(new TypeError()))vsJSON.stringify(Object.getOwnPropertyDescriptors(new DOMException())).(Required for btoa/atob and structuredClone; ref. #16, #1032)